Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [PhingTask] Fixed possible infinity loop #1294

Closed
wants to merge 3 commits into from
Closed

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Mar 29, 2020

Fixed infinity loop if a task calling a target that depends on its parent target.

Related to #1241

@siad007 siad007 changed the title [PhingTask] Fixed possible infinity loop [WIP] [PhingTask] Fixed possible infinity loop Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3372b21). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1294   +/-   ##
=========================================
  Coverage          ?   51.25%           
  Complexity        ?     9295           
=========================================
  Files             ?      479           
  Lines             ?    22752           
  Branches          ?        0           
=========================================
  Hits              ?    11662           
  Misses            ?    11090           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
classes/phing/tasks/system/PhingTask.php 78.26% <100%> (ø) 80 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3372b21...0d933bc. Read the comment docs.

@siad007
Copy link
Member Author

siad007 commented Mar 29, 2020

Closed in favor of finished and functional #1241

@siad007 siad007 closed this Mar 29, 2020
@siad007 siad007 deleted the siad007-patch-1 branch March 29, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant